Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Replace @ndhoule/extend with lodash.assignin #206

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Replace @ndhoule/extend with lodash.assignin #206

merged 1 commit into from
Sep 16, 2020

Conversation

bryanmikaelian
Copy link
Contributor

@bryanmikaelian bryanmikaelian commented Sep 15, 2020 •
edited
Loading

Description

This PR replaces @ndhoule/extend with lodash.assignin.

Test plan

  • Testing completed successfully using e2e tests and unit tests

Screen Shot 2020-09-15 at 3 15 48 PM

Screen Shot 2020-09-15 at 3 15 30 PM

Checklist

  • Thorough explanation of the issue/solution, and a link to the related issue
  • CI tests are passing
  • Unit tests were written for any new code
  • Code coverage is at least maintained, or increased.

@bryanmikaelian bryanmikaelian requested a review from a team September 15, 2020 19:08
@bryanmikaelian bryanmikaelian force-pushed the bryan/replace-extend branch 2 times, most recently from 920db00 to e02da58 Compare September 15, 2020 20:01
@bryanmikaelian bryanmikaelian merged commit 017124b into master Sep 16, 2020
@bryanmikaelian bryanmikaelian deleted the bryan/replace-extend branch September 16, 2020 17:43
juliofarah added a commit that referenced this pull request Mar 19, 2021
@juliofarah
Revert "Replace @ndhoule/extend with lodash.assignin (#206)"
52783fe 
This reverts commit 017124b.
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request Apr 16, 2021
@bryanmikaelian @hbrls
Replace @ndhoule/extend with lodash.assignin (segmentio#206)
30084d6
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request Apr 16, 2021
@bryanmikaelian @hbrls
Replace @ndhoule/extend with lodash.assignin (segmentio#206)
5144210
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request Apr 16, 2021
@bryanmikaelian @hbrls
Replace @ndhoule/extend with lodash.assignin (segmentio#206)
7e87432
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request May 31, 2021
@bryanmikaelian @hbrls
Replace @ndhoule/extend with lodash.assignin (segmentio#206)
3c68e09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juliofarah juliofarah juliofarah approved these changes

Assignees
No one assigned
Labels
Feature/Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanmikaelian @juliofarah